[PATCH] nvme-tcp: handle failing req immediately for REQ_FAILFAST_DRIVER

Sagi Grimberg sagi at grimberg.me
Wed May 25 03:38:28 PDT 2022


>>>>> I see there is a shutdown_timeout which is 5 seconds on default. Seems
>>>>> not to trigger though.
>>>>
>>>> Obviously, the shutdown_timeout is not connected to the register
>>>> writes. So we would need something like:
>>>
>>> Looking at this, its probably not what we want...
>>
>> I agree. We just have to make sure that we fail these register
>> read/writes on transport layer and don't requeue them.
>>
>>> I've inspected the code and I don't think that we should check
>>> the return code at all, we should simply fail the request. If
>>> the io_work context is running in parallel with the the error
>>> recovery handler we have a bug that we need to fix.
>>>
>>> How about this?
>>
>> Yes this would work fine for my case.
> 
> Do you want me to post this patch or are you going to post it?

Would like to get Anton's feedback on it, will ping him to reply
soon.



More information about the Linux-nvme mailing list