[RFC] nvme-rdma: Stop queues when starting with error recovery

[Daniel Wagner]

On Tue, May 24, 2022 at 04:48:27PM +0300, Sagi Grimberg wrote:
> > I suspected that nvme_stop_ctrl() might have unwanted side
> > effects. Maybe factoring out the common bits from nvme_stop_ctrl() into
> > nvme_stop_ctrl_fast() and call it from here sounds like a reasonable
> > thing to do. The function name could be better, but naming is hard.
> 
> The only name that comes to mind is nvme_stop_ctrl_noio, which is
> arguably worse... Or maybe just __nvme_stop_ctrl.

I pondered for a while and no good idea. I'd prefer __nvme_stop_ctrl()
clearly over nvme_stop_ctrl_foo() though, because I read
__nvme_stop_ctrl() as to be called by nvme_stop_ctrl().