[PATCH v2 0/2] uring-passthrough for admin commands

[Kanchan Joshi]

On Fri, May 20, 2022 at 08:01:43AM +0200, Christoph Hellwig wrote:
>On Fri, May 20, 2022 at 10:25:58AM +0530, Kanchan Joshi wrote:
>> The series enables uring-passthrough for admin-commands.
>>
>> Patch 1 is prep.
>> Patch 2 adds new opcode for admin uring-passthrough, and enables it on
>> nvme controller dev(/dev/nvmeX). It reuses the code of io-command
>> passthrough, with the only difference that commands are issued on admin
>> queue.
>
>Looks good:
>
>Reviewed-by: Christoph Hellwig <hch at lst.de>
>
>Can we add vectored admin commands as well, please?  We basically
>get them for free, so I see no reason not to add them.

Sure. By free, you mean this I suppose: 

--- a/drivers/nvme/host/ioctl.c
+++ b/drivers/nvme/host/ioctl.c
@@ -699,6 +699,9 @@ int nvme_dev_uring_cmd(struct io_uring_cmd *ioucmd, unsigned int issue_flags)
        case NVME_URING_CMD_ADMIN:
                ret = nvme_uring_cmd_io(ctrl, NULL, ioucmd, issue_flags, false);
                break;
+       case NVME_URING_CMD_ADMIN_VEC:
+               ret = nvme_uring_cmd_io(ctrl, NULL, ioucmd, issue_flags, true);
+               break;

anything else? I will fold this in, and submit v3 before Jens takes a
look.