[PATCH V3] nvme: set non-mdts limits in nvme_scan_work

Chaitanya Kulkarni chaitanyak at nvidia.com
Thu May 19 12:44:16 PDT 2022


On 5/19/22 12:28, Keith Busch wrote:
> On Wed, May 18, 2022 at 08:51:38AM -0700, Chaitanya Kulkarni wrote:
>> +	/**
>> +	 * Identify controller limits can change at controller reset due to
>> +	 * new firmware download, even though it is not common we cannot ignore
>> +	 * such scenario. Controller's non-mdts limits are reported in the unit
>> +	 * of logical blocks that is dependent on the format of attached
>> +	 * namespace. Hence re-read the limits at the time of ns allocation.
>> +	 */
> 
> I think we usually see the "/**" comment style for kernel doc.
> 
> But otherwise, patch looks good.
> 
> Reviewed-by: Keith Busch <kbusch at kernel.org>

Yes, I wanted it to be documented in kernel doc.

-ck




More information about the Linux-nvme mailing list