[PATCH 3/3] blk-mq: remove the done argument to blk_execute_rq_nowait
kernel test robot
lkp at intel.com
Wed May 18 16:23:41 PDT 2022
Hi Christoph,
I love your patch! Yet something to improve:
[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on next-20220518]
[cannot apply to mkp-scsi/for-next jejb-scsi/for-next linus/master v5.18-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Christoph-Hellwig/blk-mq-remove-__blk_execute_rq_nowait/20220517-154900
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220519/202205190712.zyCIh9kG-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/2dc03b4b4f1f1aa542a1ab6d6ff64be3d9db050c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Christoph-Hellwig/blk-mq-remove-__blk_execute_rq_nowait/20220517-154900
git checkout 2dc03b4b4f1f1aa542a1ab6d6ff64be3d9db050c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All errors (new ones prefixed by >>):
drivers/scsi/ufs/ufshpb.c: In function 'ufshpb_execute_map_req':
>> drivers/scsi/ufs/ufshpb.c:721:41: error: expected ';' before 'hpb'
721 | blk_execute_rq_nowait(req, true)
| ^
| ;
722 |
723 | hpb->stats.map_req_cnt++;
| ~~~
vim +721 drivers/scsi/ufs/ufshpb.c
683
684 static int ufshpb_execute_map_req(struct ufshpb_lu *hpb,
685 struct ufshpb_req *map_req, bool last)
686 {
687 struct request_queue *q;
688 struct request *req;
689 struct scsi_cmnd *scmd;
690 int mem_size = hpb->srgn_mem_size;
691 int ret = 0;
692 int i;
693
694 q = hpb->sdev_ufs_lu->request_queue;
695 for (i = 0; i < hpb->pages_per_srgn; i++) {
696 ret = bio_add_pc_page(q, map_req->bio, map_req->rb.mctx->m_page[i],
697 PAGE_SIZE, 0);
698 if (ret != PAGE_SIZE) {
699 dev_err(&hpb->sdev_ufs_lu->sdev_dev,
700 "bio_add_pc_page fail %d - %d\n",
701 map_req->rb.rgn_idx, map_req->rb.srgn_idx);
702 return ret;
703 }
704 }
705
706 req = map_req->req;
707
708 blk_rq_append_bio(req, map_req->bio);
709
710 req->end_io_data = map_req;
711 req->end_io = ufshpb_map_req_compl_fn;
712
713 if (unlikely(last))
714 mem_size = hpb->last_srgn_entries * HPB_ENTRY_SIZE;
715
716 scmd = blk_mq_rq_to_pdu(req);
717 ufshpb_set_read_buf_cmd(scmd->cmnd, map_req->rb.rgn_idx,
718 map_req->rb.srgn_idx, mem_size);
719 scmd->cmd_len = HPB_READ_BUFFER_CMD_LENGTH;
720
> 721 blk_execute_rq_nowait(req, true)
722
723 hpb->stats.map_req_cnt++;
724 return 0;
725 }
726
--
0-DAY CI Kernel Test Service
https://01.org/lkp
More information about the Linux-nvme
mailing list