[PATCH blktests] tests/nvme: add tests for error logging

Alan Adamson alan.adamson at oracle.com
Thu May 12 11:57:53 PDT 2022



> On May 12, 2022, at 11:56 AM, Chaitanya Kulkarni <chaitanyak at nvidia.com> wrote:
> 
> Alan,
> 
> On 5/9/22 03:52, Shinichiro Kawasaki wrote:
>> Hello Alan,
>> 
>> I ran the test case this patch adds and confirmed it works as expected. Good.
>> I found some points to improve in the patch. Please find my comments in line.
>> 
>> On Apr 29, 2022 / 15:09, Alan Adamson wrote:
>>> Test nvme error logging by injecting errors. Kernel must have FAULT_INJECTION
>>> and FAULT_INJECTION_DEBUG_FS configured to use error injector. Tests can be
>>> run with or without NVME_VERBOSE_ERRORS configured.
>>> 
>>> These test verify the functionality delivered by the follow commit:
>>>         nvme: add verbose error logging
>> 
>> The commit was already up-streamed. It will be helpful to add git hash of the
>> commit.
>> 
>>> 
> 
> 
> can you please send out V2 with Shinichiro's comments ?
I did on Wednesday.  Getting ready to send out a v3.

Alan

> 
> -ck
> 




More information about the Linux-nvme mailing list