[PATCH v2] nvme: Fix zns drives without append support to export correct permissions

[Chaitanya Kulkarni]

On 3/16/22 03:21, Pankaj Raghav wrote:
> 
> 
> On 2022-03-16 10:56, Chaitanya Kulkarni wrote:
>> On 3/16/22 02:54, Chaitanya Kulkarni wrote:
>>>
>>>> +static inline void nvme_set_disk_mode_ro(struct nvme_ns *ns)
>>>> +{
>>>> +    set_disk_ro(ns->disk, test_bit(NVME_NS_FORCE_RO, &ns->flags));
>>>> +}
>>>> +
>>>
>>> Do you have a second caller for above function ?
>>>
> ATM, no. Open coding them is an option but I don't know if it will be
> nice sprinkling the call to set_disk_ro in nvme_update_zone_info.
>>>

why are you bloating header file with the function that has no
other caller ?

>>
>> Is this function in the fast path ?
>>
> No, this is called during init.

I don't see any point of making it inline n bloating header file.

>