[PATCH] nvmet: move the call to nvmet_ns_changed out of nvmet_ns_revalidate

[Chaitanya Kulkarni]

On 3/15/22 00:19, Christoph Hellwig wrote:
> nvmet_ns_changed states via lockdep that the ns->subsys->lock must be
> held. The only caller of nvmet_ns_changed which does not acquire that
> lock is nvmet_ns_revalidate. nvmet_ns_revalidate has 3 callers,
> of which 2 do not acquire that lock: nvmet_execute_identify_cns_cs_ns
> and nvmet_execute_identify_ns. The other caller
> nvmet_ns_revalidate_size_store does acquire the lock.
> 
> Move the call to nvmet_ns_changed from nvmet_ns_revalidate to the callers
> so that they can perform the correct locking as needed.
> 
> This issue was found using a static type-based analyser and manually
> verified.
> 
> Reported-by: Niels Dossche <dossche.niels at gmail.com>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>

-ck