[PATCH 1/1] block: move sector bio member into blk_next_bio()

Chaitanya Kulkarni chaitanyak at nvidia.com
Tue Mar 8 15:19:01 PST 2022


On 3/1/22 03:25, Christoph Hellwig wrote:
> It would be nice to just calculate the sector from the previous
> bio using bio_end_sector, but that doesn't really work with the
> current blk_next_bio pattern.  It might make sense to just take the
> initial allocation case out of blk_next_bio and do that manually now
> that the bio_alloc interface makes a lot more sense.
> 

I found existing pattern easier to read with blk_next_bio(),
as removal of blk_next_bio() will result in the duplication of code for
allocation which blk_next_bio() avoids, unless I didn't understand your
comment.

-ck




More information about the Linux-nvme mailing list