[PATCH] nvme: remove support or stream based temperature hint

Jens Axboe axboe at kernel.dk
Thu Mar 3 06:50:05 PST 2022


On 3/3/22 7:42 AM, Keith Busch wrote:
> On Thu, Mar 03, 2022 at 01:50:49PM +0300, Christoph Hellwig wrote:
>> This support was added for RocksDB, but RocksDB ended up not using it.
>> At the same time drives on the open marked (vs those build for OEMs
>> for non-Linux support) that actually support streams are extremly
>> rare.  Don't bloat the nvme driver for it.
> 
> Fine with me. It looks like the early interest in streams never really
> materialized, so it's unlikely we'll hear any complaints. 
> 
> You can remove nr_streams from 'struct nvme_ctrl' while you're at it.
> 
> Reviewed-by: Keith Busch <kbusch at kernel.org>
> 
> And without nvme, there doesn't appear to be a real user for the
> write_hint anymore. All you can really do with it now is prevent
> merging, which doesn't seem useful.

Yes, I would suggest that we just prune the write hint and just leave
the fcntl() ops as stubs as a followup patch.

-- 
Jens Axboe




More information about the Linux-nvme mailing list