[PATCH] nvme: don't send unsupported NVME_ID_CNS_CS_CTRL

Wed Jun 8 09:05:52 PDT 2022

On Wed, Jun 08, 2022 at 10:03:05AM -0600, Caleb Sander wrote:
> Identify CNS values 0x05 to 0x0F are reserved in NVMe base spec 1.4.
> 0x06 was only added in spec 2.0. Our array implementing spec version 1.3
> correctly responds to this Identify with "Invalid Field in Command".
> The driver ignores an error status code here, but the reserved CNS value
> violates the spec and causes unnecessary traffic on the NVMe connection.

No, it does not "violate" the spec.  All NVMe TPs can be implement
for older spec versions as well, and regularly do.  So yes, your
array will return an error here and that is perfectly fine.