[PATCH] Add configshell-fb to install requirements

Jon Bernard jbernard at jbernard.io
Fri Jul 15 18:30:31 PDT 2022


The 'install_requires' keyword is used to specify what is minimally
needed to run correctly.  This patch adds configshell-fb as a
requirement so that nvmetcli runs correctly without additional
dependency installation.  This will not effect distribution packages,
only users that install using pip.

Also remove a reference to the 'pyparsing' package in README as it's no
longer in use.

Signed-off-by: Jon Bernard <jbernard at jbernard.io>
---
 README   | 3 ---
 setup.py | 3 ++-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/README b/README
index 6ebe666..ae95fcf 100644
--- a/README
+++ b/README
@@ -17,9 +17,6 @@ Common Package Dependencies and Problems
 Both python2 and python3 are supported via use of the 'python-six'
 package.
 
-nvmetcli uses the 'pyparsing' package -- running nvmetcli without this
-package may produce hard-to-decipher errors.
-
 Usage
 -----
 Look at Documentation/nvmetcli.txt for details.
diff --git a/setup.py b/setup.py
index 1956d95..71c7cd2 100755
--- a/setup.py
+++ b/setup.py
@@ -27,5 +27,6 @@ setup(
     maintainer_email = 'hch at lst.de',
     test_suite='nose2.collector.collector',
     packages = ['nvmet'],
-    scripts=['nvmetcli']
+    scripts=['nvmetcli'],
+    install_requires=["configshell-fb"]
     )
-- 
2.37.1




More information about the Linux-nvme mailing list