[PATCH] nvme: Fix block device naming collision

Keith Busch kbusch at kernel.org
Thu Jul 14 07:11:53 PDT 2022


On Thu, Jul 14, 2022 at 12:42:10PM +0000, Israel Rukshin wrote:
> The issue exists when multipath is enabled and the namespace is
> shared, but all the other controller checks at nvme_is_unique_nsid()
> are false. The reason for this issue is that nvme_is_unique_nsid()
> returns false when is called from nvme_mpath_alloc_disk() due to an
> uninitialized value of head->shared. The patch fixes it by setting
> head->shared before nvme_mpath_alloc_disk() is called.
> 
> Fixes: 5974ea7ce0f9 ("nvme: allow duplicate NSIDs for private namespaces")
> Signed-off-by: Israel Rukshin <israelr at nvidia.com>
> Reviewed-by: Max Gurtovoy <mgurtovoy at nvidia.com>

Looks good.

Reviewed-by: Keith Busch <kbusch at kernel.org>



More information about the Linux-nvme mailing list