[PATCH V4 1/1] nvme: Add verbose error logging

[Hannes Reinecke]

On 1/24/22 19:51, Alan Adamson wrote:
> Improves logging of NVMe errors.  If NVME_VERBOSE_ERRORS is configured,
> a verbose description of the error is logged, otherwise only status codes/bits
> is logged.
> 
> Verbose logging examples:
> [  183.333734] nvme0n1: Read(0x2) @ LBA 0, 1 blocks, Unrecovered Read Error (sct 0x2 / sc 0x81) DNR
> 
> [  227.767945] nvme0: Activate Firmware(0x10), Invalid Field in Command (sct 0x0 / sc 0x2) DNR
> 
> Non-verbose logging examples:
> [   41.280509] nvme0n1: I/O Cmd(0x2) @ LBA 0, 1 blocks, I/O Error (sct 0x2 / sc 0x81) DNR
> 
> [   77.249153] nvme0: Admin Cmd(0x10), I/O Error (sct 0x0 / sc 0x2) DNR
> 
> Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>
> Signed-off-by: Alan Adamson <alan.adamson at oracle.com>
> Reviewed-by: Himanshu Madhani <himanshu.madhani at oracle.com>
> ---
>   drivers/nvme/host/Kconfig  |   8 ++
>   drivers/nvme/host/Makefile |   2 +-
>   drivers/nvme/host/core.c   |   3 +
>   drivers/nvme/host/errors.c | 230 +++++++++++++++++++++++++++++++++++++
>   drivers/nvme/host/nvme.h   |   2 +
>   include/linux/nvme.h       |   1 +
>   6 files changed, 245 insertions(+), 1 deletion(-)
>   create mode 100644 drivers/nvme/host/errors.c
> 

Reviewed-by: Hannes Reinecke <hare at suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer