[PATCH] nvme: Use pci_iomap instead of ioremap

Christoph Hellwig hch at lst.de
Wed Jan 26 09:26:38 PST 2022


On Wed, Jan 26, 2022 at 09:22:04AM -0800, Keith Busch wrote:
> On Wed, Jan 26, 2022 at 05:33:06PM +0100, Christoph Hellwig wrote:
> > pci_iomap goes with the ioread/iowrite accessors which we absolutely
> > do not want in nvme.
> 
> It looks like the action pci_iomap() uses is based on the
> pci_resource_flags(), and should call the same "ioremap()" function we
> currently use.

Yes.  But the rule is: use ioremap when you use read*/write*, and use
pci_iomap when using ioread/iowrite.  But they should never be mixed.



More information about the Linux-nvme mailing list