[PATCH] nvme-fabrics: remove unneeded variable
Sagi Grimberg
sagi at grimberg.me
Sun Jan 9 04:53:20 PST 2022
> From: Changcheng Deng <deng.changcheng at zte.com.cn>
>
> Remove unneeded variable used to store return value.
I actually think that ret is missing an assignment in the error
case (e.g ret = -ENODEV)...
>
> Reported-by: Zeal Robot <zealci at zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng at zte.com.cn>
> ---
> drivers/nvme/host/fabrics.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
> index 7ae041e2b3fb..f79a66d4e22c 100644
> --- a/drivers/nvme/host/fabrics.c
> +++ b/drivers/nvme/host/fabrics.c
> @@ -1092,7 +1092,6 @@ static void __nvmf_concat_opt_tokens(struct seq_file *seq_file)
> static int nvmf_dev_show(struct seq_file *seq_file, void *private)
> {
> struct nvme_ctrl *ctrl;
> - int ret = 0;
>
> mutex_lock(&nvmf_dev_mutex);
> ctrl = seq_file->private;
> @@ -1106,7 +1105,7 @@ static int nvmf_dev_show(struct seq_file *seq_file, void *private)
>
> out_unlock:
> mutex_unlock(&nvmf_dev_mutex);
> - return ret;
> + return 0;
> }
>
> static int nvmf_dev_open(struct inode *inode, struct file *file)
>
More information about the Linux-nvme
mailing list