[PATCH 2/2] block: skip the fsync_bdev call in del_gendisk for surprise removals
Christoph Hellwig
hch at lst.de
Wed Feb 16 07:20:19 PST 2022
On Wed, Feb 16, 2022 at 04:18:43PM +0100, Hannes Reinecke wrote:
> My turn to be picky:
> In the previous patch you use 'set_bit()' for GD_DEAD, which to my
> knowledge doesn't imply a memory barrier.
> Yet here you rely on that for the 'test_bit()' to return the correct/most
> recent value.
> Don't we need a memory barrier here somewhere?
Well, we only do the test to skip useless work. A race is not a
problem here.
More information about the Linux-nvme
mailing list