[PATCH] nvme-multipath: fix multipath path scan

Kanchan Joshi joshiiitr at gmail.com
Wed Feb 16 06:03:20 PST 2022


On Wed, Feb 16, 2022 at 6:50 PM Christoph Hellwig <hch at lst.de> wrote:
>
> On Wed, Feb 16, 2022 at 01:57:31PM +0100, Daniel Wagner wrote:
> > > In nvme_update_zone_info, but nvme_configure_metadata is also possible.
> > > Moved setting the flag before both these.
> >
> > But the NS is not ready at this point. nvme_update_disk_info() needs run
> > before the NS can be marked as ready. Commit message e7d65803e2bb
> > ("nvme-multipath: revalidate paths during rescan") explains why.
>
> Yeah.  So the only error return from nvme_configure_metadata is a can not
> happen case which doesn't really need the error return.  So we only
> need to check nvme_update_zone_info and can set the ns life for the
> -ENODEV case there.  Something like the patch below:

It looks good to me. Can add a tested-by too if you are planning to send it?

Thanks,
-- 
Kanchan



More information about the Linux-nvme mailing list