[PATCH] nvme-multipath: fix multipath path scan

Daniel Wagner dwagner at suse.de
Wed Feb 16 04:57:31 PST 2022


On Wed, Feb 16, 2022 at 06:18:06PM +0530, Kanchan Joshi wrote:
> On Wed, Feb 16, 2022 at 1:41 PM Christoph Hellwig <hch at lst.de> wrote:
> >
> > On Wed, Feb 16, 2022 at 11:43:05AM +0530, Kanchan Joshi wrote:
> > > commit e7d65803e2bb ("nvme-multipath: revalidate paths during rescan")
> > > introduced NVME_NS_READY flag. nvme_path_is_disabled() declares path/ns
> > > to be disabled if this flag is not found to be set.
> > > This causes side-effect on namespace for which block-interface is not
> > > fully up.
> >
> > Hmm. This means for non-bdev namespaces we error out somewhere in
> > nvme_update_ns_info.  Where do we fail here, nvme_configure_metadata?
> 
> In nvme_update_zone_info, but nvme_configure_metadata is also possible.
> Moved setting the flag before both these.

But the NS is not ready at this point. nvme_update_disk_info() needs run
before the NS can be marked as ready. Commit message e7d65803e2bb
("nvme-multipath: revalidate paths during rescan") explains why.



More information about the Linux-nvme mailing list