[PATCH] nvme/pci: default to simple suspend

[Christoph Hellwig]

On Tue, Feb 08, 2022 at 09:14:21AM -0800, Keith Busch wrote:
> > I don't think this will work, as most older platforms just won't have
> > that attribute at all, and non-ACPI platforms most certainly won't have
> > it.  We'll need more quirks in the core PCI/PM code like we did for the
> > AMD mobile platforms.
> 
>  old platform + old kernel -> simple suspend
> 
>  old platform + new kernel -> nvme pm
> 
> This inevitably introduced regressions. Why should we need to quirk old
> platforms for a feature that didn't even exist when they were made?
> Shouldn't the quirk be the other way around?

Because they are broken?  If we do get a suspend request that does not
explicitly asks for the device do be disabled we need to be able to rely
on that.  Where we is not just nvme, but any driver.