[PATCH v2 1/3] nvme: fix a possible use-after-free in controller reset during load

Sagi Grimberg sagi at grimberg.me
Thu Feb 3 07:03:49 PST 2022


>> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
>> index dd18861f77c0..c11cd3a814fd 100644
>> --- a/drivers/nvme/host/core.c
>> +++ b/drivers/nvme/host/core.c
>> @@ -4251,6 +4251,8 @@ static void nvme_async_event_work(struct 
>> work_struct *work)
>>           container_of(work, struct nvme_ctrl, async_event_work);
>>       nvme_aen_uevent(ctrl);
>> +    if (ctrl->state != NVME_CTRL_LIVE)
>> +        return;
> 
> any reason you moved the queue_ready check in the transport drivers ?
> 
> Is it redundant ?
> 

Yes, see the discussion with Christoph



More information about the Linux-nvme mailing list