[PATCH 2/2] nvme: Expose cntrltype and dctype through sysfs.

[Chaitanya Kulkarni]

Sagi,

>> Nope, unfortunately.
>>
>> But maybe we can lump both attributes together in to a single ctrltype;
>> then we would have 'io', 'admin', 'discovery', 'discovery-cdc', and 
>> 'discovery-ddc'.
>>
>> Hmm?
> 
> We should really move the ctrl device node creation to
> nvme_init_ctrl_finish. I think this came up before...
> 

Unless I miss something all the transport rdma/pci/tcp/fc set ctrl
state to NVME_CTRL_CONNECTING before calling nvme_init_ctrl_finish().

Are you referring to the call of cdev_device_add() we have in the
nvme_init_ctrl() that needs to be moved into the
nvme_init_ctrl_finish() so instead of ctrl holding NVME_CTRL_NEW state
it will have NVME_CTRL_CONNECTING state ?

-ck