[PATCH 9/9] nvme: don't allow unprivileged passthrough of commands that have effects

[Christoph Hellwig]

On Thu, Dec 15, 2022 at 12:44:05PM +0530, Kanchan Joshi wrote:
> So even for operation that do not alter anything (e.g. nvme_cmd_read)
> nvme_is_write will return false, but nvme_command_effects will return
> true and we will ask for FMODE_WRITE. Is that intentional?
>
> I think doing "nvme_command_effects(ctrl, ns, opcode) & 
> ~NVME_CMD_EFFECTS_CSUPP"
> is better to avoid that?

Take a look at patch 6.