[PATCH 6/9] nvme: only return actual effects from nvme_command_effects
Christoph Hellwig
hch at lst.de
Wed Dec 14 08:13:44 PST 2022
Only return actual destructive effects from the command, and not misc
information like if the command is supported, the scope and support for
the UUID index.
Note that this causes the nvmet passthrough code to now execute
admin commands asynchronously, which it previously did not due to the
supported by in the returned effects.
Signed-off-by: Christoph Hellwig <hch at lst.de>
---
drivers/nvme/host/core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index d6f3ac102e9488..945a947f90b757 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1093,7 +1093,10 @@ u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, u8 opcode)
effects = le32_to_cpu(ctrl->effects->acs[opcode]);
effects |= nvme_known_admin_effects(opcode);
- return effects;
+ /* only return actual command effects and not misc information */
+ return effects & (NVME_CMD_EFFECTS_CSUPP | NVME_CMD_EFFECTS_LBCC |
+ NVME_CMD_EFFECTS_NCC | NVME_CMD_EFFECTS_NIC |
+ NVME_CMD_EFFECTS_CCC | NVME_CMD_EFFECTS_CSE_MASK);
}
EXPORT_SYMBOL_NS_GPL(nvme_command_effects, NVME_TARGET_PASSTHRU);
--
2.35.1
More information about the Linux-nvme
mailing list