[PATCH 1/2] nvme: add nvme_opcode_str function for all nvme cmd types

[Engel, Amit]

Correct, fixed

-----Original Message-----
From: Caleb Sander <csander at purestorage.com> 
Sent: Monday, 12 December 2022 18:33
To: Engel, Amit <Amit.Engel at Dell.com>
Cc: sagi at grimberg.me; linux-nvme at lists.infradead.org
Subject: Re: [PATCH 1/2] nvme: add nvme_opcode_str function for all nvme cmd types


[EXTERNAL EMAIL] 

On Mon, Dec 12, 2022 at 6:33 AM <amit.engel at dell.com> wrote:
>
> +const unsigned char *nvme_get_fabrics_opcode_str(u8 opcode) {
> +       if (opcode < ARRAY_SIZE(nvme_admin_ops) && nvme_fabrics_ops[opcode])
> +               return nvme_fabrics_ops[opcode];

Why bounds-check opcode against nvme_admin_ops but access nvme_fabrics_ops?