[PATCH] nvme-tcp: add additional info for nvme_tcp_timeout log

[Engel, Amit]

Ok, np

-----Original Message-----
From: Sagi Grimberg <sagi at grimberg.me> 
Sent: Monday, 12 December 2022 12:17
To: Engel, Amit <Amit.Engel at Dell.com>; linux-nvme at lists.infradead.org
Subject: Re: [PATCH] nvme-tcp: add additional info for nvme_tcp_timeout log


[EXTERNAL EMAIL] 


> From: Amit Engel <Amit.Engel at dell.com>
> 
> This provides additional details about the rq/cmd that is timed out

I think that you should separate the patches to add the fabrics opcode string and then another patch to have nvme-tcp call it.

Also, please make sure that this is fine with/without CONFIG_NVME_VERBOSE_ERRORS and provide example log message for each variant in the commit-msg.