[PATCH] nvme-tcp: add additional info for nvme_tcp_timeout log

[Engel, Amit]

ok, so let's go with cid (which includes gen+tag) and opc?

new log:

Dec 06 14:54:38 nc9127122.drm.lab.emc.com kernel: nvme nvme0: queue 9: timeout cid 0x6051 opcode 0x2 type 4

Existing log:

Dec 06 14:54:38 nc9127122.drm.lab.emc.com kernel: nvme nvme0: queue 9: timeout request 0x51 type 4


-----Original Message-----
From: Sagi Grimberg <sagi at grimberg.me> 
Sent: Monday, 5 December 2022 22:12
To: Engel, Amit <Amit.Engel at Dell.com>; linux-nvme at lists.infradead.org
Cc: Grupi, Elad <Elad.Grupi at dell.com>
Subject: Re: [PATCH] nvme-tcp: add additional info for nvme_tcp_timeout log


[EXTERNAL EMAIL] 


> Yes, io timeout is obtainable via sysfs.
> But this io_timeout param is writable and the user can modify this value at any time.
> So I still find it usufl to have this value as part of this log.

I am sorry but I see no point in logging a static value that is obtainable via sysfs... I Don't see this practice in any other block device so it is unclear why this would be needed here when no one else is doing this?