> On Tue, Dec 06, 2022 at 04:43:45PM +0800, Chao Leng wrote: >> tcp should set NVME_F_BLOCKING in ctrl->ops->flags, I did not see that in this patch. >> Did I miss something? > > No, I missed that I got lost during my rebase. With that looks good, Reviewed-by: Sagi Grimberg <sagi at grimberg.me>