[PATCH 2/2] nvme-auth: remove the redundant req->cqe->result.u16 assignment operation

Hannes Reinecke hare at suse.de
Thu Aug 11 23:02:18 PDT 2022


On 8/12/22 05:12, Jackie Liu wrote:
> From: Jackie Liu <liuyun01 at kylinos.cn>
> 
> req->cqe->result.u16 has already been assigned in the previous line, no
> need to do it again.
> 
> Signed-off-by: Jackie Liu <liuyun01 at kylinos.cn>
> ---
>   drivers/nvme/target/fabrics-cmd.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/nvme/target/fabrics-cmd.c b/drivers/nvme/target/fabrics-cmd.c
> index f91a56180d3d..c1dfdfb92ebf 100644
> --- a/drivers/nvme/target/fabrics-cmd.c
> +++ b/drivers/nvme/target/fabrics-cmd.c
> @@ -332,7 +332,6 @@ static void nvmet_execute_io_connect(struct nvmet_req *req)
>   	req->cqe->result.u16 = cpu_to_le16(ctrl->cntlid);
>   
>   	pr_debug("adding queue %d to ctrl %d.\n", qid, ctrl->cntlid);
> -	req->cqe->result.u16 = cpu_to_le16(ctrl->cntlid);
>   	if (nvmet_has_auth(ctrl))
>   		nvmet_init_auth(ctrl, req);
>   

Reviewed-by: Hannes Reinecke <hare at suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman



More information about the Linux-nvme mailing list