[PATCH] nvme: allow ioctl to submit io command with dif for NVMeoF

[Keith Busch]

On Wed, Aug 03, 2022 at 05:44:36PM +0800, Chao Leng wrote:
> If nvme over fabrics support t10dif, NVME_NS_EXT_LBAS and
> NVME_NS_METADATA_SUPPORTED of ns->features will be set to 1.
> Now nvme_submit_io do not allow the metadata if NVME_NS_EXT_LBAS of
> ns->features is setted. Indeed It should allow the metadata if both
> NVME_NS_EXT_LBAS and NVME_NS_METADATA_SUPPORTED of ns->features are setted.

I'm not sure. As a passthrough interface, don't you want to set up the host
buffers with the inline metadata instead of relying on the HBA to splice
separate ones?

If you really want to control this kind of thing, it would be better to use
NVME_IOCTL_IO_CMD instead of NVME_IOCTL_SUBMIT_IO.