[PATCH] nvme-core: mark passthru requests RQF_QUIET flag

Chaitanya Kulkarni chaitanyak at nvidia.com
Thu Apr 7 13:10:48 PDT 2022


On 4/7/22 04:52, Sagi Grimberg wrote:
> 
>>> Using RQF_QUIET or blk_rq_is_passrhrough() will mean no nvme 
>>> admin-passthru command will log an error.
>>> I ran into this using the blktests I’m coding up for verbose errors.  
>>> Is this the behavior we want?
>>
>> Well, you submitted the logging so we're curious about your use case.
>> SCSI skips logging errors for internally submitted commands, but not for
>> userspace passthrough.  So we could move the RQF_QUIET into
>> __nvme_submit_sync_cmd / nvme_keep_alive_work / nvme_timeout / etc.
>>
> 
> Makes sense to me

This was my initial proposal to fix the call sites with internal
passthru commands [1], so this should work.

-ck

[1]
http://lists.infradead.org/pipermail/linux-nvme/2022-April/031160.html




More information about the Linux-nvme mailing list