[PATCH] nvme-core: mark passthru requests RQF_QUIET flag

hch at lst.de hch at lst.de
Thu Apr 7 01:51:13 PDT 2022


On Wed, Apr 06, 2022 at 10:06:06PM +0000, Alan Adamson wrote:
> Using RQF_QUIET or blk_rq_is_passrhrough() will mean no nvme admin-passthru command will log an error.
> I ran into this using the blktests I’m coding up for verbose errors.  Is this the behavior we want?

Well, you submitted the logging so we're curious about your use case.
SCSI skips logging errors for internally submitted commands, but not for
userspace passthrough.  So we could move the RQF_QUIET into
__nvme_submit_sync_cmd / nvme_keep_alive_work / nvme_timeout / etc.



More information about the Linux-nvme mailing list