[PATCH 1/3] nvmet: check for subsystem type in nvmet_find_get_subsys()

[John Meneghini]

On 4/5/22 01:53, Hannes Reinecke wrote:
> 
> Will have to check; might be that this is a left-over from the previous attempt of handling discovery subsystems just like any 
> other subsystem.
> 
> However, this is just part of a larger patchset to support unique discovery controller NQNs. And the overarching question here is:
> 
> Do we want to support unique discovery controller NQNs in nvmet?
> 
> Previously there was a rather strict policy of implementing only the bare necessities in nvmet, and unique discovery controller 
> NQNs is arguably not a necessary thing.

I think the question is: do we want to support unique discovery controller NQNs at all?

> So the whole discussion gets pretty pointless if we decide _not_ to support it after all.

I'm really concerned about the idea of having NO support for unique discovery controller NQNs in nvmet.  If Linux is going to 
support unique discovery NQNs in nvme/host then I think we need to have support for unique discovery NQNs in nvme/target.

Without this, there is just no way to test anything.  I want the ability to test NVMe protocol features like this w/out having 
to rely on external hardware, if possible.

/John

> Cheers,
> 
> Hannes