[PATCH V3 nvme-cli 1/2] initialize disk "access" variable

[Chengjike (ISSP)]

在 2021/9/29 4:45, Sagi Grimberg 写道:
>
>> (This is a prep patch, which provides functions for the next "patch 
>> 2/2")
>> When it is failed to get nvme_id_ns data from NVMe Subsystem.
>
> If there was a failure the nsid should be -1, and all the size info 
> should be zero, that is enough of an indication that the ns is "faulty".
>
> Also live/faulty is not a good terminology for path access.
> Maybe full/partial or complete/incomplete.
>
> I thought that this was about showing the completeness of the
> path access for a given ns, regardless of failure of identify-ns...
>
> Meaning that if I have a ns with 2 paths, where one is live and the
> other is connecting/resetting then "Path Access" would be "incomplete"
> or "partial".. Also in the case where all paths are live, but some
> have ANA state "inaccessible" or "persistent loss" then "Path Access"
> would be "partial" and only if all paths are "live" and ANA accessible
> i.e. "optimized/non-optimized" it will show "full/complete" Path
> Access...
>
> Otherwise, I don't see the point in adding this information to
> nvme list output.
> .

Hi,Sagi and Chaitanya

Thank you for your comments.
It is a good suggestion that setting nsid to "-1" indicates a faulty disk,
and I resend patch V4 based on your comments later.