[PATCH] nvme/mpath: fix hang when disk goes live over reconnect

Christoph Hellwig hch at lst.de
Mon Oct 4 09:57:25 PDT 2021


On Mon, Oct 04, 2021 at 10:46:12AM -0600, Anton Eidelman wrote:
> How do we proceed with this fix?

Please resend with the suggested updates.

> I believe error propagation here is not wanted because:
> 1) A failure to fetch or parse the ANA log should not be considered
>    an error in ctrl initialization.

We must handle error that are due to a controller failing to initialize.

> 2) Such error will not cause problems in teardown.
> 3) The same failure is possible in ANA work and we do not take
>    any action in such case.

Failing in a workqueue is different from failing in the initialization
path.

> 4) Adding support for failure to nvme_start_ctrl() adds complexity
>    and does not look useful due to the above 1-3.
---end quoted text---



More information about the Linux-nvme mailing list