[regression] blktests nvme/002 nvme/016 nvme/017 failed from v5.16-rc1

[Hannes Reinecke]

On 11/27/21 1:39 PM, Yi Zhang wrote:
> Hello
> blktests[2] failed from v5.16-rc1, and the bisecting showed it was
> introduced from [1], pls check it.
> 
> [1]
> 2953b30b1d9feb1bc555682e64e6479d197b9231 is the first bad commit
> commit 2953b30b1d9feb1bc555682e64e6479d197b9231
> Author: Hannes Reinecke <hare at suse.de>
> Date:   Mon Oct 18 17:21:38 2021 +0200
> 
>      nvmet: register discovery subsystem as 'current'
> 
>      Register the discovery subsystem as the 'current' discovery subsystem,
>      and add a new discovery log page entry for it.
> 
>      Signed-off-by: Hannes Reinecke <hare at suse.de>
>      Signed-off-by: Christoph Hellwig <hch at lst.de>
> 
>   drivers/nvme/target/core.c      |  1 +
>   drivers/nvme/target/discovery.c | 17 +++++++++++------
>   2 files changed, 12 insertions(+), 6 deletions(-)
> 
> [2]
> # ./check nvme/002 nvme/016 nvme/017
> nvme/002 (create many subsystems and test discovery)         [failed]
>      runtime  2.092s  ...  12.200s
>      --- tests/nvme/002.out 2021-11-27 00:28:12.066040369 -0500
>      +++ /root/blktests/results/nodev/nvme/002.out.bad 2021-11-27
> 07:31:13.452891961 -0500
>      @@ -1,3003 +1,3006 @@
>       Running nvme/002
>      -Discovery Log Number of Records 1000, Generation counter X
>      +Discovery Log Number of Records 1001, Generation counter X
>       =====Discovery Log Entry 0======
>       trtype:  loop
>      -subnqn:  blktests-subsystem-0
>      +subnqn:  nqn.2014-08.org.nvmexpress.discovery
>      ...
>      (Run 'diff -u tests/nvme/002.out
> /root/blktests/results/nodev/nvme/002.out.bad' to see the entire diff)
> nvme/016 (create/delete many NVMeOF block device-backed ns and test
> discovery) [failed]
>      runtime  7.444s  ...  7.894s
>      --- tests/nvme/016.out 2021-11-27 00:28:12.069040481 -0500
>      +++ /root/blktests/results/nodev/nvme/016.out.bad 2021-11-27
> 07:31:21.446186124 -0500
>      @@ -1,6 +1,9 @@
>       Running nvme/016
>      -Discovery Log Number of Records 1, Generation counter X
>      +Discovery Log Number of Records 2, Generation counter X
>       =====Discovery Log Entry 0======
>       trtype:  loop
>      +subnqn:  nqn.2014-08.org.nvmexpress.discovery
>      +=====Discovery Log Entry 1======
>      ...
>      (Run 'diff -u tests/nvme/016.out
> /root/blktests/results/nodev/nvme/016.out.bad' to see the entire diff)
> nvme/017 (create/delete many file-ns and test discovery)     [failed]
>      runtime    ...  7.578s
>      --- tests/nvme/017.out 2021-11-27 00:28:12.069040481 -0500
>      +++ /root/blktests/results/nodev/nvme/017.out.bad 2021-11-27
> 07:31:29.103467922 -0500
>      @@ -1,6 +1,9 @@
>       Running nvme/017
>      -Discovery Log Number of Records 1, Generation counter X
>      +Discovery Log Number of Records 2, Generation counter X
>       =====Discovery Log Entry 0======
>       trtype:  loop
>      +subnqn:  nqn.2014-08.org.nvmexpress.discovery
>      +=====Discovery Log Entry 1======
>      ...
>      (Run 'diff -u tests/nvme/017.out
> /root/blktests/results/nodev/nvme/017.out.bad' to see the entire diff)
> 
But that was precisely the point, returning more information for 
discovery ...

I'll be sending a patch to update blktests.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer