[PATCH 06/12] nvme-fabrics: decode 'authentication required' connect error

Himanshu Madhani himanshu.madhani at oracle.com
Mon Nov 15 07:25:42 PST 2021



On 11/12/21 06:59, Hannes Reinecke wrote:
> The 'connect' command might fail with NVME_SC_AUTH_REQUIRED, so we
> should be decoding this error, too.
> 
> Signed-off-by: Hannes Reinecke <hare at suse.de>
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
> Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>
> ---
>   drivers/nvme/host/fabrics.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
> index c5a2b71c5268..a1343a0790f6 100644
> --- a/drivers/nvme/host/fabrics.c
> +++ b/drivers/nvme/host/fabrics.c
> @@ -332,6 +332,10 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl,
>   		dev_err(ctrl->device,
>   			"Connect command failed: host path error\n");
>   		break;
> +	case NVME_SC_AUTH_REQUIRED:
> +		dev_err(ctrl->device,
> +			"Connect command failed: authentication required\n");
> +		break;
>   	default:
>   		dev_err(ctrl->device,
>   			"Connect command failed, error wo/DNR bit: %d\n",
> 

Reviewed-by: Himanshu Madhani <himanshu.madhani at oracle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering



More information about the Linux-nvme mailing list