[PATCH libnvme] Implement 'dhchap_key' host and controller attributes

[Sagi Grimberg]

On 11/14/21 3:38 PM, Hannes Reinecke wrote:
> On 11/14/21 11:38 AM, Sagi Grimberg wrote:
>>> Implement a 'dhchap_key' attribute for the nvme_host structure to
>>> support the 'dhchap_secret' connection argument, and a
>>> 'dhchap_key' attribute for the nvme_controller structure to support
>>> the 'dhchap_ctrl_secret' connection argument.
>>
>> Hannes, can you add an example of a json entry to the change log?
>> Ideally there is some sort of documentation on what is the
>> format and how to populate the config file?
>>
>> It is unclear to me how the user is supposed to work with it.
>> Is there a dump config functionality like we discussed before?
> 
> I would rather keep the json functionality separate from this.
> Yes, I know that we really need json functionality to make it usable, 
> but then the same could be said for other options, too.

You add this code:
+	attr_obj = json_object_object_get(host_obj, "dhchap_key");
+	if (attr_obj)
+		nvme_host_set_dhchap_key(h, json_object_get_string(attr_obj));

Hence I ask, how is it populated? and how is the json formatted?

> 
> And the problem here is that we'll need to coordinate libnvme and 
> nvme-cli updates to get the whole thing to build, so I'd rather keep the 
> json update separate from this one.

Huh, nvme-cli access this config anywhere?

I ask myself how can someone understand what on earth this json looks
like, how to generate it, and how it is used. Don't get me wrong,
I think its great that a parse-able json config exists, but it is
completely undocumented which makes me wonder who uses it at all.