[PATCH v3 1/2] nvme: Look for StorageD3Enable on companion ACPI device instead

[N, Shyjumon]

Hi 
Reply in-line. 

Have a good day.

Thank you and Regards,
Shyjumon N.
-----Original Message-----
From: Christoph Hellwig <hch at lst.de> 
Sent: Monday, May 31, 2021 12:17 PM
To: Mario Limonciello <mario.limonciello at amd.com>
Cc: Keith Busch <kbusch at kernel.org>; Jens Axboe <axboe at fb.com>; Christoph Hellwig <hch at lst.de>; Sagi Grimberg <sagi at grimberg.me>; Rafael J . Wysocki <rjw at rjwysocki.net>; open list:NVM EXPRESS DRIVER <linux-nvme at lists.infradead.org>; linux-acpi at vger.kernel.org; rrangel at chromium.org; david.e.box at linux.intel.com; Shyam-sundar.S-k at amd.com; Alexander.Deucher at amd.com; prike.liang at amd.com; N, Shyjumon <shyjumon.n at intel.com>; Derrick, Jonathan <jonathan.derrick at intel.com>
Subject: Re: [PATCH v3 1/2] nvme: Look for StorageD3Enable on companion ACPI device instead

On Fri, May 28, 2021 at 11:02:34AM -0500, Mario Limonciello wrote:
> The documentation around the StorageD3Enable property hints that it 
> should be made on the PCI device.  This is where newer AMD systems set 
> the property and it's required for S0i3 support.
> 
> So rather than look for nodes of the root port only present on Intel 
> systems, switch to the companion ACPI device for all systems.
> David Box from Intel indicated this should work on Intel as well.

I think we need to wait for the confirmation from David.  This looks good, but I'd like to see testing.  I also wonder how many of the simple suspend quirks we can drop with this.

Shyjumon and Jon, can you retests the platforms quirked in
1fae37accfc5 ("nvme/pci: Add sleep quirk for Samsung and Toshiba drives") with this fix?

Shyjumon>> Yes, I do agree we need to test this also. However the boards where which I had these issues are not in my remote access now (as the work frequency on this boards are less and also due to Covid situation),
                        It might  take some time for me to test. I will update as soon as I can.