[PATCH] nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME

Keith Busch kbusch at kernel.org
Mon May 24 08:18:54 PDT 2021


On Fri, May 21, 2021 at 02:51:15PM -0700, Sagi Grimberg wrote:
> We need to select NVME_CORE.

This looks fine and matches what the other drivers are doing, but I
think a more appropriate dependency should have NVME_FABRICS select
NVME_CORE.

> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---
>  drivers/nvme/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
> index a44d49d63968..c0826b3c617c 100644
> --- a/drivers/nvme/host/Kconfig
> +++ b/drivers/nvme/host/Kconfig
> @@ -71,7 +71,7 @@ config NVME_FC
>  config NVME_TCP
>  	tristate "NVM Express over Fabrics TCP host driver"
>  	depends on INET
> -	depends on BLK_DEV_NVME
> +	select NVME_CORE
>  	select NVME_FABRICS
>  	select CRYPTO
>  	select CRYPTO_CRC32C
> -- 
> 2.27.0
> 



More information about the Linux-nvme mailing list