[PATCHv3] nvme-mpath: delete disk after last connection

Hannes Reinecke hare at suse.de
Thu May 6 16:54:29 BST 2021


On 5/6/21 2:08 PM, Christoph Hellwig wrote:
> On Thu, May 06, 2021 at 02:47:00AM -0700, Sagi Grimberg wrote:
>> That is my assumption as well, and its a problem that by default
>> a pci device unplugs or a fabrics controller is lost and removed
>> the stacked mdraid on top stops functioning.
>>
>> I still think we can fix that by changing the semantics of implicit
>> queue_if_no_path and restore it as an explicit opt-in.
> 
> So at very least we need to make sure we have the opt-in available before
> changing the defaults.
> 

But what _is_ the default?
PCI and fabrics have different defaults; for PCI the device goes away if 
the last path (ie the controller) goes away, for fabrics it doesn't if 
the device is mounted.

Do we want to keep the difference in behaviour?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer



More information about the Linux-nvme mailing list