[PATCH 1/1] nvmet: do not allow model_number exceed 40 bytes

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Tue Mar 16 03:40:37 GMT 2021


Max,

On 3/15/21 14:50, Sagi Grimberg wrote:
>>> According to the NVM specifications, the model number size should be
>>> 40 bytes (bytes 63:24 of the Identify Controller data structure).
>>> Therefore, any attempt to store a value into model_number which
>>> exceeds 40 bytes should return an error.
>>>
>>> Reviewed-by: Max Gurtovoy <mgurtovoy at nvidia.com>
>>> Signed-off-by: Noam Gottlieb <ngottlieb at nvidia.com>
>> The patch looks good to me, but is this patch not intended for 5.13 ?
>>
>> Since for 5.13 we have nvmet_subsys_attr_model_store_locked(), this
>> patch uses nvmet_subsys_attr_model_store().
>>
>> Is this a fix for 5.12-rc  ?
> I think this patch can wait for 5.13 for sure, maybe needs a Fixes
> tag to help it get back to stable...
>

That's what I thought, can you please respin unless there is a reason for
this to be in 5.12 ?







More information about the Linux-nvme mailing list