[PATCH 0/4] nvme-fabrics: remove struct zeroout memset calls

Keith Busch kbusch at kernel.org
Tue Jun 15 11:42:26 PDT 2021


On Mon, Jun 14, 2021 at 07:45:50PM -0700, Chaitanya Kulkarni wrote:
> Hi,
> 
> While reviewing the code I did removed the calls to zero out structures
> using memset() for the lio target, which are reviewed and accepted in
> the linux kernel tree. (see [1])
> 
> This patch series is based on the same cleanup pattern for NVMe host.
> This will allow us to have uniform pattern in the future code review to
> avoid similar calls which seems unnecessary.
> 
> If this is accepted I'll gradually convert the rest of the host code
> mainly core and pci.

This looks good, and aligns with the local style. For future cleanups, I
think it would be fine to do it a single patch instead of individual
patches per function.

Reviewed-by: Keith Busch <kbusch at kernel.org>



More information about the Linux-nvme mailing list