[PATCH] nvmet/fc: do not check for invalid target port in nvmet_fc_handle_fcp_rqst()

James Smart jsmart2021 at gmail.com
Thu Jun 3 16:52:54 PDT 2021


On 5/25/2021 5:54 AM, Hannes Reinecke wrote:
> When parsing a request in nvmet_fc_handle_fcp_rqst() we should not
> check for invalid target ports; if we do the command is aborted
> from the fcp layer, causing the host to assume a transport error.
> Rather we should still forward this request to the nvmet layer, which
> will then correctly fail the command with an appropriate error status.
> 
> Signed-off-by: Hannes Reinecke <hare at suse.de>

Well, correct behavior either way as I to would think it is a transport 
error if the port hasn't been tied to any subsystem yet.  But, I guess 
it's fine to let nvmet_find_get_subsys() see the null port pointer and 
fail Connect with INVALID_PARAM|DNR as well.

so - ok

Reviewed-by: James Smart <jsmart2021 at gmail.com>

-- james




More information about the Linux-nvme mailing list