[PATCH v5 net-next 00/36] nvme-tcp receive and tarnsmit offloads

[Sagi Grimberg]

>> * Add transmit offload patches
> 
> But to be honest, the previous one was already mostly unreviewable,
> but this is now far beyond this.   Please try to get anything that
> is generally useful first in smaller series and the come back with
> a somewhat reviewable series.  That also means that at least for the
> code I care about (nvme) the patches should be grouped together,
> and actually provide meaningful functionality in each patch.  Right
> now even trying to understand what you add to the nvme code requires
> me to jump all over a gigantic series.

I agree as well. It is difficult to review.
The order should be:
1. ulp_ddp interface
2. nvme-tcp changes
3. mlx5e changes

Also even beyond grouping patches together I have 2 requests:
1. Please consolidate ddp routines under a single ifdef (also minimize
the ifdef in call-sites).
2. When consolidating functions, try to do this as prep patches
documenting in the change log that it is preparing to add ddp. Its
difficult digesting both at times.