[PATCH 1/1] nvme: introduce nvme_transport_sgl_desc structure

[Sagi Grimberg]

>>>> Currently the tcp and fc transports use nvme_sgl_desc structure to
>>>> describe transport data blocks. Replace it with a new structure that
>>>> describes the Transport SGL Data Block according to the NVMe
>>>> specification.
>>>
>>> What is the point?
>>
>> I think its ok to be more aligned to the spec, and have the transport
>> sgl represented in the code. Don't see any harm in that.
>>
>>> Note that we should probably still clear the reserved space anyway.
>>
>> Definitely we should clear it.
> 
> don't you think it's cleared already ?
> 
> if not, lets clear also other rsvd fields while we're here.
> 
> Each driver call nvme_setup_cmd before mapping the data and this 
> function clears the SQE (if (!(req->rq_flags & RQF_DONTPREP)))..

Yea, I guess its fine to rely on nvme_setup_cmd for it.