[PATCH v4 01/20] nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP

[Christoph Hellwig]

On Mon, Jul 05, 2021 at 06:09:58PM +0300, Shai Malin wrote:
> > > +static void __exit nvme_tcp_ofld_cleanup_module(void)
> > > +{
> > > +     nvmf_unregister_transport(&nvme_tcp_ofld_transport);
> > > +}
> >
> > Looking at the final result this doesn't do much.  Assuming we want
> > to support these kinds of whacky offloads (which I'd rather not do),
> > the proper way would be to allow registering multiple transport_ops
> > structures for a given name rather adding an indirection that duplicates
> > a whole lot of code.
> 
> In that case, would you prefer that we invoke the tcp-offload from
> within the tcp flow?
> Should it be with the same transport name (“tcp”) or with a different
> transport name (“tcp_offload”)?
> 
> Also, would you prefer that we register the offload device driver
> directly to blk_mq layer or through the tcp-offload layer?

As said, we should allow the different offload drivers register
as te offload transport and just iterate through the multiple instances
of the transport until we find a match instead of duplicating the
registration infrastructure.