[PATCH v4 09/20] qedn: Add qedn - Marvell's NVMeTCP HW offload device driver

[Shai Malin]

On Thu, 1 Jul 2021 at 16:41, Christoph Hellwig <hch at lst.de> wrote:
> On Tue, Jun 29, 2021 at 03:47:32PM +0300, Prabhakar Kushwaha wrote:
> > From: Shai Malin <smalin at marvell.com>
> >
> > This patch will present the skeleton of the qedn driver.
> > The new driver will be added under "drivers/nvme/hw/qedn" and will be
> > enabled by the Kconfig "Marvell NVM Express over Fabrics TCP offload".
>
> I don't see why we need a separate hw/ directory.   nvme-pci.c already
> is very much a hardware driver.

We will restructure and keep only the bare minimum qedn.c under nvme/host.

>
> > +config NVME_QEDN
> > +     tristate "Marvell NVM Express over Fabrics TCP offload"
> > +     depends on NVME_TCP_OFFLOAD
>
> I think it also depends on PCI.

Thanks!

>
> This whole patch is a bit pointless.  In general splitting a driver
> submission into multiple patches is not very helpful unless the later
> patches add pretty much optional and clearly separatable bits.  Otherwise
> it just becomes really hard to review.

Understood. We will improve it.