[PATCH v2] nvme: avoid "(efault)" from nvme_sysfs_show_subsysnqn()

Christoph Hellwig hch at lst.de
Wed Feb 3 11:51:49 EST 2021


On Wed, Feb 03, 2021 at 01:31:13PM +0100, Martin Wilck wrote:
> > This is just papering over symptoms.  We should not be sending
> > events or display sysfs files until the controlle is live.
> 
> I don't follow. What's wrong with a "connecting" controller device in
> sysfs? 
> 
> Controllers can loose connectivity any time. What's the difference
> between a controller that is reconnecting after a connection loss and a
> freshly created controller that's just not live yet? You wouldn't
> delete the former from sysfs, I suppose.

What is wrong is that we should only add the device and thus send the
uevent notifcations when the device is fully set up.



More information about the Linux-nvme mailing list