[PATCHv2] nvme: print out valid arguments when reading from /dev/nvme-fabrics

Chaitanya Kulkarni chaitanyak at nvidia.com
Mon Dec 13 13:47:30 PST 2021


  Can we use "\n" instead of "," ?
>> with that change it looks :-
>>
>> instance=-1,cntlid=-1
>> transport=%s
>> traddr=%s
>> trsvcid=%s
>> nqn=%s
>> queue_size=%d
>> nr_io_queues=%d
>> reconnect_delay=%d
>> ctrl_loss_tmo=%d
>> keep_alive_tmo=%d
>> hostnqn=%s
>> host_traddr=%s
>> host_iface=%s
>> hostid=%s
>> duplicate_connect
>> disable_sqflow
>> hdr_digest
>> data_digest
>> nr_write_queues=%d
>> nr_poll_queues=%d
>> tos=%d
>> fast_io_fail_tmo=%d
>> discovery
>>
> The ',' format is being used for a successful connect, so I'd rather
> stay with that to make parsing easier.
> 

hmmm, looks good.

Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>



More information about the Linux-nvme mailing list